Preferences > Controller: a few UX fixes #10821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ronso0
commented
Aug 25, 2022
•
ronso0
commented
- mark mapping dirty when I/O table was changed (those changes were wiped previously)
- prevent loop with empty name in 'Save as ...' dialog (saving couldn't be canceled after seleting Save As..)
- keep selected mapping when saving pending changes in previous mapping (info of selected mapping was displayed but in the combobox the previous mapping was selected)
ronso0
commented
Aug 29, 2022
| this, | ||
| [this]() { | ||
| m_pMidiPreset->setDirty(true); | ||
| }); |
There was a problem hiding this comment.
note that dataChanged() is emitted also when an non/existing values are 'confirmed' with Return. IMO this is the only minor regression if users are not used to this default QAbstractItemView/QSpinBox/QTextEdit behaviour, though it's now consistent with the existing GUI (skins, preferences).
Swiftb0y
reviewed
Aug 29, 2022
ronso0
force-pushed
the
pref-controller__2.3
branch
from
8bdf16f to
057ad01
Compare
ronso0
commented
Aug 29, 2022
| savePreset(); | ||
| if (savePreset()) { | ||
| // We might have saved the previous preset with a new name, | ||
| // so update the preset combobox. |
There was a problem hiding this comment.
... and select the mapping."
will !fixup once this change set is accepted.
Swiftb0y
approved these changes
Aug 29, 2022
|
@ferranpujolcamins maybe? |
|
LGTM, thank you |
|
I'll merge to main later this eve.. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.