Prevent temporary copies of QList

mixxxdj · Dec 11, 2019 · d1e0d1e · d1e0d1e
1 parent 98ce67d
commit d1e0d1e
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 4 deletions.
diff --git a/src/library/dao/playlistdao.cpp b/src/library/dao/playlistdao.cpp
@@ -458,7 +458,7 @@ void PlaylistDAO::removeTracksFromPlaylist(int playlistId, QList<int> positions)
     //qDebug() << "PlaylistDAO::removeTrackFromPlaylist"
     //         << QThread::currentThread() << m_database.connectionName();
     ScopedTransaction transaction(m_database);
-    for (const auto position : positions) {
+    for (const auto position : qAsConst(positions)) {
         removeTracksFromPlaylistInner(playlistId, position);
     }
     transaction.commit();

diff --git a/src/library/playlistfeature.cpp b/src/library/playlistfeature.cpp
@@ -237,7 +237,7 @@ void PlaylistFeature::slotPlaylistContentChanged(QSet<int> playlistIds) {
         return;
     }
 
-    for (const auto playlistId : playlistIds) {
+    for (const auto playlistId : qAsConst(playlistIds)) {
         enum PlaylistDAO::HiddenType type = m_playlistDao.getHiddenType(playlistId);
         if (type == PlaylistDAO::PLHT_NOT_HIDDEN ||
             type == PlaylistDAO::PLHT_UNKNOWN) { // In case of a deleted Playlist

diff --git a/src/library/playlisttablemodel.cpp b/src/library/playlisttablemodel.cpp
@@ -132,7 +132,9 @@ void PlaylistTableModel::removeTracks(const QModelIndexList& indices) {
         trackPositions.append(trackPosition);
     }
 
-    m_pTrackCollection->getPlaylistDAO().removeTracksFromPlaylist(m_iPlaylistId, trackPositions);
+    m_pTrackCollection->getPlaylistDAO().removeTracksFromPlaylist(
+            m_iPlaylistId,
+            std::move(trackPositions));
 }
 
 void PlaylistTableModel::moveTrack(const QModelIndex& sourceIndex,

diff --git a/src/library/setlogfeature.cpp b/src/library/setlogfeature.cpp
@@ -337,7 +337,7 @@ void SetlogFeature::slotPlaylistContentChanged(QSet<int> playlistIds) {
         return;
     }
 
-    for (const auto playlistId : playlistIds) {
+    for (const auto playlistId : qAsConst(playlistIds)) {
         enum PlaylistDAO::HiddenType type = m_playlistDao.getHiddenType(playlistId);
         if (type == PlaylistDAO::PLHT_SET_LOG ||
             type == PlaylistDAO::PLHT_UNKNOWN) { // In case of a deleted Playlist