-
Notifications
You must be signed in to change notification settings - Fork 886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
error while running with webpack bundle in nodejs #439
Comments
Its due to this fgnass/domino#146 |
Is there a workaround, anyone know of ? |
Not familiar with webpack, so the workaround in general terms:
For reference, discussion about separating turndown and the DOM implementation: #265 . |
@mohit-singh-pepper did you found a solution ? |
The domino library looks abandoned and had compatibility issues with the latest nextjs versions. Luckily, turndownjs accepts a JSDOM document as input and not only raw text. Workaround for: * mixmark-io/turndown#439 (occurred after upgrading nextjs from 13.4 to 13.5) * mixmark-io/turndown#378 (occurred after upgrading nextjs from 12.X to 13.X)
For anyone still running into this problem, the following worked for me (based on the commit from @julienc91 above):
|
I think this issue should be solved with the latest Turndown release 7.2.0. Can you confirm @mohit-singh-pepper ? |
This should be solved with the introduction of custom domino fork in the latest release #461. |
See: mixmark-io/turndown#439 fgnass/domino#146 (cherry picked from commit baad3ae)
Getting following error while trying to run turndown. I am using esbuild to get the bundle for same.
The text was updated successfully, but these errors were encountered: