Deprecate --no-force-pass

This seems like a confusing option, and is dominated by the much clearer `--check`

CHANGELOG.md

@@ -2,13 +2,18 @@
 
 All notable changes to insta and cargo-insta are documented here.
 
+## 1.40.0
+
+- Deprecate `--no-force-pass` in `cargo-insta`.  The `--check` option covers the
+  same functionality and has a clearer name.
+
 ## 1.39.0
 
 - Fixed a bug in `require_full_match`.  #485
 
 - Fixed a bug that caused snapshot and module names to sometimes be inaccurate.  #483
 
-- Insta will no longer error when removing snapshots that were already removed.  #484
+- Insta will no longer error when attempting to remove snapshots that were already removed.  #484
 
 - Added support for trailing commas in inline snapshots.  #472
 

cargo-insta/src/cli.rs

@@ -138,8 +138,8 @@ struct TestCommand {
     /// Exclude packages from the test
     #[structopt(long, value_name = "SPEC")]
     exclude: Option<String>,
-    /// Disable force-passing of snapshot tests
-    #[structopt(long)]
+    /// [Deprecated] Disable force-passing of snapshot tests
+    #[structopt(long, hidden = true)]
     no_force_pass: bool,
     /// Prevent running all tests regardless of failure
     #[structopt(long)]
@@ -876,6 +876,11 @@ fn prepare_test_runner<'snapshot_ref>(
     }
     if !cmd.no_force_pass {
         proc.env("INSTA_FORCE_PASS", "1");
+    } else {
+        eprintln!(
+            "{}: `--no-force-pass` is deprecated. Please use --check to immediately raise an error on any non-matching snapshots.",
+            style("warning").bold().yellow()
+        );
     }
     proc.env(
         "INSTA_UPDATE",

insta/tests/test_basic.rs

@@ -67,7 +67,7 @@ mod nested {
 fn test_trailing_commas() {
     assert_snapshot!("Testing",);
     assert_snapshot!("Testing", "name",);
-    assert_snapshot!("Testing", "name", "expr",);
+    assert_snapshot!("Teting", "name", "exr",);
     #[cfg(feature = "yaml")]
     assert_yaml_snapshot!(vec![1, 2, 3, 4, 5],);
 }