Swapped adm-zip out for zip.js #6018
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amndeep Singh Mann <[email protected]>
|
|
Currently failing the frontend tests due to node not finding the TransformStream object for some reason even though node supports it as of v18. It works fine on my machine but that's cause it's a browser running the frontend code. I need to see if we need a polyfill or if I can muck with stuff to get node to work properly. |
Signed-off-by: Amndeep Singh Mann <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adm-zipwas causing issues such as the followingwhich was causing heimdall to have runtime errors and not display itself properly. This had been throwing warnings before but had started to actually cause this runtime problem when making other changes so I decided to fix it.
Easiest thing to do was to replace it wholesale. Sidebenefit is that I found
zip.jswhich has built-in types so we have that benefit.The only problem is that it is not a commonjs dependency so we have to do a dynamic import which is a bit ugly due to the lack of top level await that we're currently suffering from. I'm working on getting us able to use that functionality, but that shouldn't be a blocker for this pr.
Also I cleaned up the files we touched a little bit.