fix corner case in collapse_vars (#4875)

fixes #4874
mishoo · Apr 27, 2021 · 4cccc01 · 4cccc01
1 parent 97bd56b
commit 4cccc01
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 0 deletions.
diff --git a/lib/compress.js b/lib/compress.js
@@ -1963,6 +1963,7 @@ merge(Compressor.prototype, {
                         } else if (candidate instanceof AST_VarDef) {
                             replaced = !compressor.exposed(def) && def.references.length == def.replaced;
                         }
+                        value_def.last_ref = false;
                         value_def.single_use = false;
                     }
                     if (replaced && !remove_candidate(candidate)) statements.splice(stat_index, 1);

diff --git a/test/compress/collapse_vars.js b/test/compress/collapse_vars.js
@@ -9030,3 +9030,30 @@ issue_4868: {
     }
     expect_stdout: "PASS"
 }
+
+issue_4874: {
+    options = {
+        collapse_vars: true,
+        evaluate: true,
+        reduce_vars: true,
+        toplevel: true,
+        unused: true,
+    }
+    input: {
+        var a;
+        a = null;
+        (function(b) {
+            for (var c in b = b && b[console.log("PASS")])
+                console;
+        })(a = 42);
+    }
+    expect: {
+        var a;
+        null;
+        (function(b) {
+            for (var c in a && a[console.log("PASS")])
+                console;
+        })(a = 42);
+    }
+    expect_stdout: "PASS"
+}