Add improvements in json ld definition for webpage #56
Conversation
| .creator((props.creators ?? [])|map(org => organization(org))|default(null)) | ||
| .copyrightHolder((props.authors.organizations ?? [])|map(org => organization(org))|default(null)) | ||
| .copyrightYear(props.dateCreated|date('Y')) | ||
| .id(siteUrl|default(null)) |
There was a problem hiding this comment.
Is this correct? All webpage id values will end up being the same. Previously this was being set to props.url ~ '#webpage'.
There was a problem hiding this comment.
On reference URL, it was updated intentionally to siteUrl so I did here as well but I think keeping it props.url ~ '#webpage' would be better. Reverted now.
There was a problem hiding this comment.
What is the reason for one being better than the other?
There was a problem hiding this comment.
Keeping it siteUrl will make it the same for all web pages and the Id should be unique for each webpage.
There was a problem hiding this comment.
@pl-mnm Can you chime in here? The older code in the boilerplate has the webpage ID set to props.url ~ '#webpage' but the newer versions of our JSON-LD code, like in Blume, have the ID set to siteUrl.
- What is the ID supposed to be?
- What should we retain in the boilerplate?
There was a problem hiding this comment.
Tbh I'm not sure I understood all these subtleties. This is something @souvikdg and I had come up with and I think he'll be better placed to tell us what's required.
No description provided.