fix: ember-qunit dependencies check #2209
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 8, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not 100% sure if it is on
ember-cli-mirageside or https://github.com/embroider-build/embroiderBut in projects using ember-mocha and latest version of https://github.com/embroider-build/embroider, we enter this condition -> https://github.com/miragejs/ember-cli-mirage/blob/master/addon-test-support/index.js#L6
It leads to test suite failing because
window.QUnitisundefined, sowindow.QUnit.configthrows an errorReproduced randomly on this repo -> ndekeister-us/Admin#1 ; commit
c6dec4ba829975297d00f0c3fe438f052b1bd257(clone it, run tests)It seems that when using
macroCondition(dependencySatisfies(...))(as seen in https://github.com/ember-cli/ember-exam/blob/master/addon-test-support/-private/get-test-loader.js#L11 for example) it fix the issueTested on
(Should we add a new project to
test-projectsusing ember-mocha?)As i'm not able to reproduce it anymore, putting this PR on draft until i'm able to reproduce the issue and, by so, be sure that the fix is needed (maybe someone was wrong with my environment)