Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for is_inline param to create_database function #19

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Add support for is_inline param to create_database function #19

merged 1 commit into from
Mar 26, 2024

Conversation

cl-fl
Copy link
Contributor

@cl-fl cl-fl commented Mar 25, 2024

Notion API now supports creating new databases as inline of parent pages via the is_inline parameter in body of the request.
This PR adds the is_inline parameter to create_database function, set to False by default

Allows to select whether the newly created database should display inline of parent page or not (defaults to False)
@cl-fl cl-fl changed the base branch from main to develop March 25, 2024 18:15
@minwook-shin minwook-shin self-assigned this Mar 26, 2024
@minwook-shin minwook-shin added the enhancement New feature or request label Mar 26, 2024
@minwook-shin minwook-shin self-requested a review March 26, 2024 00:57
Copy link
Owner

@minwook-shin minwook-shin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for submit your PR.
checked the PR code, tested it, and found no issue, so i will releasing it today.

@minwook-shin minwook-shin merged commit bebf512 into minwook-shin:develop Mar 26, 2024
@minwook-shin
Copy link
Owner

@cl-fl cl-fl deleted the add-database-is_inline branch March 26, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants