Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated phonenumbers and django-phonenumber-field #2757

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Updated phonenumbers and django-phonenumber-field #2757

merged 2 commits into from
Apr 2, 2024

Conversation

ammar92
Copy link
Contributor

@ammar92 ammar92 commented Apr 2, 2024

Changes

This updates phonenumbers and the indirect dependency django-phonenumber-field used by django-two-factor-auth 1.16.0. I've ran makemigrations to confirm that there are no model changes/ migrations

Issue link

Closes #2359

Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue; tickets have been created for newly discovered issues.
  • I have written unit tests for the changes or fixes I made.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have performed a self-review of my code and refactored it to the best of my abilities.

Communication

  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have made corresponding changes to the documentation, if necessary.
  • I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.

Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@ammar92 ammar92 added the dependencies Pull requests that update a dependency file label Apr 2, 2024
@ammar92 ammar92 marked this pull request as ready for review April 2, 2024 09:50
@ammar92 ammar92 requested a review from a team as a code owner April 2, 2024 09:50
@stephanie0x00
Copy link
Contributor

Checklist for QA:

  • I have checked out this branch, and successfully ran a fresh make reset.
  • I confirmed that there are no unintended functional regressions in this branch:
    • I have managed to pass the onboarding flow
    • Objects and Findings are created properly
    • Tasks are created and completed properly
  • I confirmed that the PR's advertised feature or hotfix works as intended.

What works:

Looks good, I've tested this by generating a new totp code as a first time user.

What doesn't work:

n/a

Bug or feature?:

n/a

@dekkers dekkers merged commit cf9655a into main Apr 2, 2024
11 checks passed
@dekkers dekkers deleted the fix/upgrade-django-phonenumber-field branch April 2, 2024 13:12
jpbruinsslot added a commit that referenced this pull request Apr 4, 2024
@jpbruinsslot
Merge branch 'main' into feature/mula/refactor-queue
652fc2c 
* main: (51 commits)
  Fix static files for container images/Debian packages when DEBUG is on (#2742)
  OOI selection at Aggregate report does not remember changed selection (#2619)
  fix schema errors on empty / missing schemas (#2744)
  Updated `phonenumbers` and `django-phonenumber-field` (#2757)
  Remove octopoes coverage workflow (#2755)
  Bump actions/configure-pages from 4 to 5 (#2745)
  Add xtdb-cli tool to Octopoes (#2733)
  Dont report vulnerabilities without version info of the software for snyk (#2730)
  Feature/boefjes to oci images (#2709)
  Query non-reference fields and subclass-specific fields through path queries (#2662)
  Fix in System Specific (#2732)
  Plugins overview in appendix not showing any plugins (#2694)
  Feat stepper design v2 (#2704)
  Undo project-directory in Rocky (#2734)
  Remove Docker Compose: "version" (#2718)
  Upgrade `pre-commit` hooks (#2729)
  Fix #1739 (#2705)
  Improve generate report (#2633)
  Fix critical vulnerability counter (#2712)
  Fix pdf alignment (#2674)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dekkers dekkers dekkers approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
KAT
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore: update django-phonenumber-field
4 participants
@ammar92 @stephanie0x00 @dekkers @underdarknl