Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements of Aggregate Report #2643

Merged
merged 9 commits into from
Mar 20, 2024
Merged

Conversation

madelondohmen
Copy link
Contributor

@madelondohmen madelondohmen commented Mar 13, 2024

Problem

See issue #2635 for the full description of the problem

!!! Note: There are some other problems in the reports that will be fixed with issue #2588. These won't be fixed with this PR.

Changes

This PR makes the following fixes in the Aggregate Report:

  • Make the font size smaller of the text "You've selected all objects in the previous step"
  • "System specific" is now only visible if there's data in this section

Besides this, it also makes these improvements to both the Aggregate Report as the Generate Report:

  • Sorting open ports (from low to high) + extra unit test to check this
  • Sorting the report types while selecting (they're now in a random order)

Issue link

Closes #2635

Demo

Open ports sorting:

afbeelding

Sorting report types:

afbeelding

Fix font size:

afbeelding


Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue; tickets have been created for newly discovered issues.
  • I have written unit tests for the changes or fixes I made.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have performed a self-review of my code and refactored it to the best of my abilities.

Communication

  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have made corresponding changes to the documentation, if necessary.
  • I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@madelondohmen madelondohmen self-assigned this Mar 13, 2024
@madelondohmen madelondohmen marked this pull request as ready for review March 13, 2024 13:53
@madelondohmen madelondohmen requested a review from a team as a code owner March 13, 2024 13:53
Copy link
Contributor

@ammar92 ammar92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@stephanie0x00
Copy link
Contributor

Checklist for QA:

  • I have checked out this branch, and successfully ran a fresh make reset.
  • I confirmed that there are no unintended functional regressions in this branch:
    • I have managed to pass the onboarding flow
    • Objects and Findings are created properly
    • Tasks are created and completed properly
  • I confirmed that the PR's advertised feature or hotfix works as intended.

What works:

The changes look good. No comments.

What doesn't work:

n/a

Bug or feature?:

n/a

@underdarknl underdarknl merged commit 79e2a4c into main Mar 20, 2024
10 checks passed
@underdarknl underdarknl deleted the fix/fixes-in-aggregate-report branch March 20, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Improvements for Aggregate Report
4 participants