Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated prison-api alerts endpoints with hmpps-alerts-api endpoints #2810

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Replace deprecated prison-api alerts endpoints with hmpps-alerts-api endpoints #2810

wants to merge 10 commits into from

Conversation

bill-moj
Copy link
Contributor

@bill-moj bill-moj commented Dec 19, 2024 •
edited
Loading

Replaced the following deprecated Prison API alerts endpoint calls with the Alerts API equivalent:

  1. POST /api/bookings/offenderNo/{agencyId}/alerts
  2. GET /api/bookings/{bookingId}/alerts/v2
  3. GET /api/reference-domains/alertTypes
  4. GET /api/offenders/{offenderNo}/bookings/latest/alerts

@bill-moj bill-moj marked this pull request as ready for review December 20, 2024 10:56
iterative-it
iterative-it approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@iterative-it iterative-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iterative-it iterative-it iterative-it approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bill-moj @iterative-it