-
-
Notifications
You must be signed in to change notification settings - Fork 715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v8-compile-cache for faster loading times & DRM support #2037
Conversation
This reverts commit b22a368.
This pull request got expanded, beacuse now it also adds (experimental) Widevine support for websites like Netflix or Spotify. How does it work?If possible, Min will load the Widevine libraries from an installed instance of Google Chrome and it will load it with Electron. Why does it use this method?The main three reasons are:
On which platform does it work?The code support Linux, Windows and MacOS, for x86 both for 32 and 64bits, but this support for the DRM requires testing on all of the platforms. Why is this one big pull request and not two?This is beacuse with this pull requests all the dependencies for the project got updated to the latest version, resolving many security and compatibility issues, so both the changes are tested with this new project update. |
Have you measured this before/after to see if it's faster? The reason I ask is that for For Widevine - I don't understand the licensing well enough to know what's permissible or not at the moment. In order to avoid potential issues, I think it's best not to support that. Sorry. |
Hi. I've checked, and Electron.js does (by default) use code caching. I'll close this PR, but I will chec the Widevine License/ToS for checking if is possible to embed the DRM (legally). |
In the PR I also update the dependencies for the project; if you wish, I can make another PR with just the updates. (see I also fixed a bug that blocked the use of SharedArrayBuffers (without this API sites like Google Earth can't run) in this pull request |
This pull requests introduces
v8-compile-cache
, a small library that speed up instantiation time using V8's code cache system.At the moment,
v8-compile-cache
is used injs/default.js
andmain/main.js
.If needed,
require('v8-compile-cache);
can be used in other modules if they need a (little) speed up.