Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: clang format broken under osx #38427

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: clang format broken under osx #38427

wants to merge 1 commit into from
+10 −11

Conversation

tedxu
Copy link
Contributor

@tedxu tedxu commented Dec 13, 2024 •
edited
Loading

See: #38434

@sre-ci-robot sre-ci-robot requested review from czs007 and yhmo December 13, 2024 03:20
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tedxu
To complete the pull request process, please assign jiaoew1991 after the PR has been reviewed.
You can assign the PR to them by writing /assign @jiaoew1991 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Dec 13, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 13, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 13, 2024

@tedxu Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

tedxu
tedxu commented Dec 13, 2024
View reviewed changes
internal/core/build-support/add_cpp_license.sh
@@ -9,7 +9,7 @@ fi
cat ${LICENSE} > /dev/null || exit -1

FILES=`find ${FOLDER} \
| grep -E "(*\.cpp$|*\.h$|*\.cu$)" \
| grep "(\.cpp\|\.h\|\.cu)$" \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it a typo here? 'cu' should be 'cc'?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cu might cuda files

@codecov Codecov
Copy link

codecov bot commented Dec 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.89%. Comparing base (0d7a89a) to head (e73ae81).
Report is 14 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38427      +/-   ##
==========================================
- Coverage   80.90%   80.89%   -0.01%     
==========================================
  Files        1376     1373       -3     
  Lines      192740   192959     +219     
==========================================
+ Hits       155938   156097     +159     
- Misses      31289    31350      +61     
+ Partials     5513     5512       -1
Components Coverage Δ
Client 74.58% <ø> (ø)
Core 68.91% <ø> (-0.01%) ⬇️
Go 83.00% <ø> (-0.02%) ⬇️

see 64 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuanYang-cn XuanYang-cn XuanYang-cn left review comments

@czs007 czs007 Awaiting requested review from czs007

@yhmo yhmo Awaiting requested review from yhmo

Assignees
No one assigned
Labels
ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tedxu @sre-ci-robot @XuanYang-cn