Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsubscribe topic in DataCoord #15353

Merged
merged 1 commit into from
Jan 24, 2022
Merged

Conversation

sunby
Copy link
Contributor

@sunby sunby commented Jan 24, 2022

Signed-off-by: sunby [email protected]

/kind improvement

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Jan 24, 2022
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Jan 24, 2022
@mergify mergify bot added the dco-passed DCO check passed. label Jan 24, 2022
@mergify
Copy link
Contributor

mergify bot commented Jan 24, 2022

@sunby E2e jenkins job failed, comment /run-checks can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jan 24, 2022

@sunby E2e jenkins job failed, comment /run-checks can trigger the job again.

@mergify mergify bot added needs-dco DCO is missing in this pull request. dco-passed DCO check passed. and removed dco-passed DCO check passed. needs-dco DCO is missing in this pull request. labels Jan 24, 2022
@mergify
Copy link
Contributor

mergify bot commented Jan 24, 2022

@sunby E2e jenkins job failed, comment /run-checks can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jan 24, 2022

@sunby E2e jenkins job failed, comment /run-checks can trigger the job again.

@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sunby, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants