Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean flowGraph if watchChannel failed #15303

Merged
merged 1 commit into from
Jan 20, 2022

Conversation

xige-16
Copy link
Contributor

@xige-16 xige-16 commented Jan 19, 2022

fix issue: #15293
/kind bug
Signed-off-by: xige-16 [email protected]

@sre-ci-robot sre-ci-robot added the kind/bug Issues or changes related a bug label Jan 19, 2022
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jan 19, 2022
@mergify mergify bot added the dco-passed DCO check passed. label Jan 19, 2022
@mergify
Copy link
Contributor

mergify bot commented Jan 19, 2022

@xige-16 E2e jenkins job failed, comment /run-checks can trigger the job again.

@xige-16 xige-16 force-pushed the fix-rewatch-deltaChannel branch from ad778b2 to 2174dfe Compare January 19, 2022 13:18
@bigsheeper
Copy link
Contributor

/lgtm

@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #15303 (2174dfe) into master (bbb672c) will increase coverage by 0.10%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15303      +/-   ##
==========================================
+ Coverage   79.63%   79.73%   +0.10%     
==========================================
  Files         450      450              
  Lines       61441    61408      -33     
==========================================
+ Hits        48928    48965      +37     
+ Misses      10168    10115      -53     
+ Partials     2345     2328      -17     
Impacted Files Coverage Δ
internal/querynode/task.go 83.33% <72.05%> (+4.66%) ⬆️
internal/querynode/collection_replica.go 87.46% <100.00%> (+0.73%) ⬆️
internal/querynode/data_sync_service.go 100.00% <100.00%> (ø)
internal/querynode/flow_graph_delete_node.go 81.25% <0.00%> (-7.30%) ⬇️
...nternal/util/rocksmq/client/rocksmq/client_impl.go 78.15% <0.00%> (-1.69%) ⬇️
internal/util/flowgraph/node.go 72.26% <0.00%> (-0.85%) ⬇️
internal/querycoord/task.go 80.20% <0.00%> (+0.19%) ⬆️
internal/querycoord/task_scheduler.go 75.38% <0.00%> (+0.35%) ⬆️
internal/proxy/impl.go 84.48% <0.00%> (+0.49%) ⬆️
... and 4 more

@czs007
Copy link
Collaborator

czs007 commented Jan 20, 2022

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xige-16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit c132302 into milvus-io:master Jan 20, 2022
@xige-16 xige-16 deleted the fix-rewatch-deltaChannel branch July 14, 2022 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants