Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsubscribe channel after query node down #15230

Merged
merged 1 commit into from
Jan 17, 2022

Conversation

xige-16
Copy link
Contributor

@xige-16 xige-16 commented Jan 15, 2022

fix issue: #15193
/kind bug
Signed-off-by: xige-16 [email protected]

@sre-ci-robot sre-ci-robot added the kind/bug Issues or changes related a bug label Jan 15, 2022
@sre-ci-robot sre-ci-robot added area/internal-api size/XL Denotes a PR that changes 500-999 lines. labels Jan 15, 2022
@mergify mergify bot added the dco-passed DCO check passed. label Jan 15, 2022
@mergify
Copy link
Contributor

mergify bot commented Jan 15, 2022

@xige-16 E2e jenkins job failed, comment /run-checks can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jan 15, 2022

@xige-16 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jan 15, 2022

@xige-16 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jan 15, 2022

@xige-16 E2e jenkins job failed, comment /run-checks can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jan 16, 2022

@xige-16 E2e jenkins job failed, comment /run-checks can trigger the job again.

@codecov
Copy link

codecov bot commented Jan 16, 2022

Codecov Report

Merging #15230 (da492d3) into master (1601a61) will decrease coverage by 0.48%.
The diff coverage is 73.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15230      +/-   ##
==========================================
- Coverage   80.12%   79.63%   -0.49%     
==========================================
  Files         445      450       +5     
  Lines       60829    61426     +597     
==========================================
+ Hits        48738    48918     +180     
- Misses       9787    10160     +373     
- Partials     2304     2348      +44     
Impacted Files Coverage Δ
internal/indexcoord/meta_table.go 83.28% <ø> (+0.17%) ⬆️
internal/querynode/impl.go 72.25% <0.00%> (-1.45%) ⬇️
internal/rootcoord/root_coord.go 79.39% <25.00%> (-0.26%) ⬇️
internal/rootcoord/task.go 76.98% <42.85%> (-2.28%) ⬇️
internal/querycoord/task.go 80.01% <50.00%> (-1.03%) ⬇️
internal/querycoord/query_coord.go 78.85% <69.23%> (-0.35%) ⬇️
internal/querycoord/channel_unsubscribe.go 75.00% <75.00%> (ø)
internal/querycoord/meta.go 82.16% <93.22%> (+0.86%) ⬆️
internal/querycoord/cluster.go 81.70% <100.00%> (-0.31%) ⬇️
internal/querycoord/querynode.go 70.80% <100.00%> (-1.10%) ⬇️
... and 39 more

@sre-ci-robot sre-ci-robot added size/XXL Denotes a PR that changes 1000+ lines. and removed size/XL Denotes a PR that changes 500-999 lines. labels Jan 17, 2022
@mergify
Copy link
Contributor

mergify bot commented Jan 17, 2022

@xige-16 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jan 17, 2022

@xige-16 E2e jenkins job failed, comment /run-checks can trigger the job again.

2 similar comments
@mergify
Copy link
Contributor

mergify bot commented Jan 17, 2022

@xige-16 E2e jenkins job failed, comment /run-checks can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jan 17, 2022

@xige-16 E2e jenkins job failed, comment /run-checks can trigger the job again.

@czs007
Copy link
Collaborator

czs007 commented Jan 17, 2022

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xige-16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007
Copy link
Collaborator

czs007 commented Jan 17, 2022

/lgtm

@sre-ci-robot sre-ci-robot merged commit dfc6670 into milvus-io:master Jan 17, 2022
@xige-16 xige-16 deleted the unsubscribe branch July 14, 2022 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/internal-api ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants