Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't remove nodeInfo when querycoord panic at loadBalanceTask #15189

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

xige-16
Copy link
Contributor

@xige-16 xige-16 commented Jan 13, 2022

fix issue: #14077
/kind bug
Signed-off-by: xige-16 [email protected]

@sre-ci-robot sre-ci-robot added the kind/bug Issues or changes related a bug label Jan 13, 2022
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Jan 13, 2022
@mergify mergify bot added the dco-passed DCO check passed. label Jan 13, 2022
@mergify
Copy link
Contributor

mergify bot commented Jan 13, 2022

@xige-16 ut workflow job failed, comment rerun ut can trigger the job again.

@czs007
Copy link
Collaborator

czs007 commented Jan 13, 2022

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xige-16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #15189 (700547a) into master (008e08a) will decrease coverage by 0.03%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15189      +/-   ##
==========================================
- Coverage   80.18%   80.15%   -0.04%     
==========================================
  Files         445      445              
  Lines       60800    60805       +5     
==========================================
- Hits        48753    48736      -17     
- Misses       9748     9772      +24     
+ Partials     2299     2297       -2     
Impacted Files Coverage Δ
internal/querycoord/task.go 81.23% <16.66%> (-0.27%) ⬇️
internal/querycoord/channel_allocator.go 97.56% <0.00%> (-2.44%) ⬇️
internal/querynode/query_collection.go 81.14% <0.00%> (-0.85%) ⬇️
internal/datacoord/server.go 71.91% <0.00%> (-0.60%) ⬇️
internal/proxy/impl.go 83.99% <0.00%> (-0.50%) ⬇️
internal/indexcoord/meta_table.go 83.11% <0.00%> (-0.26%) ⬇️
internal/indexcoord/index_coord.go 79.37% <0.00%> (+0.29%) ⬆️
...nternal/util/rocksmq/client/rocksmq/client_impl.go 78.15% <0.00%> (+0.84%) ⬆️
internal/indexnode/indexnode_mock.go 84.84% <0.00%> (+1.13%) ⬆️
internal/datacoord/segment_manager.go 82.81% <0.00%> (+2.74%) ⬆️

@sre-ci-robot sre-ci-robot merged commit 384d316 into milvus-io:master Jan 13, 2022
@xige-16 xige-16 deleted the test-search branch July 14, 2022 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants