Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic when recover querynode failed #15161

Merged
merged 1 commit into from
Jan 12, 2022

Conversation

xige-16
Copy link
Contributor

@xige-16 xige-16 commented Jan 11, 2022

fix issue: #14077
Signed-off-by: xige-16 [email protected]

@mergify mergify bot added the dco-passed DCO check passed. label Jan 11, 2022
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Jan 11, 2022
@mergify
Copy link
Contributor

mergify bot commented Jan 11, 2022

@xige-16 ut workflow job failed, comment rerun ut can trigger the job again.

@codecov
Copy link

codecov bot commented Jan 11, 2022

Codecov Report

Merging #15161 (8ecdfc9) into master (6e847ff) will increase coverage by 0.04%.
The diff coverage is 48.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15161      +/-   ##
==========================================
+ Coverage   80.08%   80.13%   +0.04%     
==========================================
  Files         443      443              
  Lines       60798    60794       -4     
==========================================
+ Hits        48692    48715      +23     
+ Misses       9797     9772      -25     
+ Partials     2309     2307       -2     
Impacted Files Coverage Δ
internal/querycoord/task.go 81.30% <48.14%> (+0.16%) ⬆️
internal/indexnode/indexnode_mock.go 83.71% <0.00%> (-3.04%) ⬇️
internal/distributed/querycoord/client/client.go 69.94% <0.00%> (-2.19%) ⬇️
internal/proxy/segment.go 87.54% <0.00%> (-1.89%) ⬇️
internal/querynode/query_node.go 85.40% <0.00%> (-0.73%) ⬇️
internal/datanode/data_node.go 77.73% <0.00%> (-0.54%) ⬇️
internal/core/src/segcore/SegmentGrowingImpl.cpp 64.56% <0.00%> (-0.26%) ⬇️
internal/core/src/segcore/SegmentSealedImpl.h 100.00% <0.00%> (ø)
internal/core/src/segcore/SegmentGrowingImpl.h 89.65% <0.00%> (ø)
... and 9 more

@czs007
Copy link
Collaborator

czs007 commented Jan 12, 2022

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xige-16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 4e956ee into milvus-io:master Jan 12, 2022
@xige-16 xige-16 deleted the balance-panic branch July 14, 2022 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants