Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix storage memory leak caused by runtime.SetFinalizer #15100

Merged

Conversation

congqixia
Copy link
Contributor

Fix #15098
Related #14747 #13934

/kind bug
/cc @godchen0212

Signed-off-by: Congqi Xia [email protected]

@sre-ci-robot sre-ci-robot added the kind/bug Issues or changes related a bug label Jan 10, 2022
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved size/M Denotes a PR that changes 30-99 lines. labels Jan 10, 2022
@mergify mergify bot added the dco-passed DCO check passed. label Jan 10, 2022
@godchen0212
Copy link
Contributor

/lgtm

@codecov
Copy link

codecov bot commented Jan 10, 2022

Codecov Report

Merging #15100 (963ce00) into master (45f1f97) will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15100      +/-   ##
==========================================
+ Coverage   80.05%   80.12%   +0.07%     
==========================================
  Files         443      443              
  Lines       60997    60946      -51     
==========================================
+ Hits        48832    48834       +2     
+ Misses       9827     9783      -44     
+ Partials     2338     2329       -9     
Impacted Files Coverage Δ
internal/storage/binlog_reader.go 93.47% <ø> (-0.53%) ⬇️
internal/storage/binlog_writer.go 85.43% <ø> (+6.15%) ⬆️
internal/storage/event_reader.go 100.00% <ø> (ø)
internal/storage/event_writer.go 82.49% <ø> (+8.19%) ⬆️
...nternal/util/rocksmq/client/rocksmq/client_impl.go 75.63% <0.00%> (-1.69%) ⬇️
internal/datacoord/segment_manager.go 81.78% <0.00%> (-1.04%) ⬇️
internal/datacoord/meta.go 88.09% <0.00%> (-0.15%) ⬇️
internal/msgstream/mq_msgstream.go 75.54% <0.00%> (+0.77%) ⬆️
internal/indexcoord/priority_queue.go 84.15% <0.00%> (+0.99%) ⬆️
... and 1 more

@mergify mergify bot added the ci-passed label Jan 10, 2022
@sre-ci-robot sre-ci-robot merged commit 4369e08 into milvus-io:master Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Memory Leak in storage codec for Finalizer circle reference
3 participants