Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file not close when ReadAll returns error in local chunk manager #15068

Merged

Conversation

congqixia
Copy link
Contributor

Fix #15067

/kind bug

Signed-off-by: Congqi Xia [email protected]

@sre-ci-robot sre-ci-robot added the kind/bug Issues or changes related a bug label Jan 10, 2022
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved size/XS Denotes a PR that changes 0-9 lines. labels Jan 10, 2022
@mergify mergify bot added the dco-passed DCO check passed. label Jan 10, 2022
@mergify
Copy link
Contributor

mergify bot commented Jan 10, 2022

@congqixia E2e jenkins job failed, comment /run-checks can trigger the job again.

@codecov
Copy link

codecov bot commented Jan 10, 2022

Codecov Report

Merging #15068 (4f36e69) into master (97ea978) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15068   +/-   ##
=======================================
  Coverage   80.05%   80.06%           
=======================================
  Files         443      443           
  Lines       61010    61011    +1     
=======================================
+ Hits        48841    48847    +6     
+ Misses       9827     9821    -6     
- Partials     2342     2343    +1     
Impacted Files Coverage Δ
internal/storage/local_chunk_manager.go 78.18% <100.00%> (+0.40%) ⬆️
internal/distributed/querycoord/client/client.go 69.94% <0.00%> (-2.19%) ⬇️
internal/rootcoord/root_coord.go 79.65% <0.00%> (+0.12%) ⬆️
internal/querycoord/task.go 81.13% <0.00%> (+0.19%) ⬆️
internal/querycoord/channel_allocator.go 100.00% <0.00%> (+2.43%) ⬆️
...nternal/util/rocksmq/client/rocksmq/client_impl.go 78.15% <0.00%> (+2.52%) ⬆️

@mergify mergify bot added the ci-passed label Jan 10, 2022
@godchen0212
Copy link
Contributor

/gtlm

@godchen0212
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit 998ebcc into milvus-io:master Jan 10, 2022
@congqixia congqixia deleted the fix_localstorage_defer_close branch February 28, 2022 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: File not closed when ReadAll returns error in LocalChunkManager.Read
3 participants