Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check leakage of index CGO object #14630

Merged

Conversation

longjiquan
Copy link
Contributor

Signed-off-by: dragondriver [email protected]
/kind improvement

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Dec 30, 2021
@mergify mergify bot added the dco-passed DCO check passed. label Dec 30, 2021
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Dec 30, 2021
@mergify
Copy link
Contributor

mergify bot commented Dec 30, 2021

@DragonDriver E2e jenkins job failed, comment /run-checks can trigger the job again.

@longjiquan longjiquan force-pushed the 1230-check-leakage-of-index branch from ce5ca83 to f8e3f1d Compare December 30, 2021 12:07
@mergify
Copy link
Contributor

mergify bot commented Dec 30, 2021

@DragonDriver E2e jenkins job failed, comment /run-checks can trigger the job again.

@longjiquan longjiquan force-pushed the 1230-check-leakage-of-index branch from f8e3f1d to bd2f56e Compare December 31, 2021 02:51
@mergify
Copy link
Contributor

mergify bot commented Dec 31, 2021

@DragonDriver E2e jenkins job failed, comment /run-checks can trigger the job again.

@longjiquan longjiquan force-pushed the 1230-check-leakage-of-index branch from bd2f56e to 660e1ac Compare January 4, 2022 02:28
@mergify
Copy link
Contributor

mergify bot commented Jan 4, 2022

@DragonDriver E2e jenkins job failed, comment /run-checks can trigger the job again.

@longjiquan longjiquan force-pushed the 1230-check-leakage-of-index branch from 660e1ac to b518e81 Compare January 5, 2022 09:17
@codecov
Copy link

codecov bot commented Jan 5, 2022

Codecov Report

Merging #14630 (b518e81) into master (46f8d2d) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14630      +/-   ##
==========================================
+ Coverage   80.09%   80.13%   +0.04%     
==========================================
  Files         442      442              
  Lines       60978    60985       +7     
==========================================
+ Hits        48838    48870      +32     
+ Misses       9783     9767      -16     
+ Partials     2357     2348       -9     
Impacted Files Coverage Δ
internal/indexnode/index.go 90.16% <100.00%> (+0.59%) ⬆️
internal/querycoord/channel_allocator.go 97.56% <0.00%> (-2.44%) ⬇️
internal/indexnode/indexnode_mock.go 84.90% <0.00%> (-1.89%) ⬇️
internal/proxy/segment.go 87.92% <0.00%> (-1.51%) ⬇️
internal/msgstream/mq_msgstream.go 74.77% <0.00%> (-0.78%) ⬇️
internal/indexcoord/meta_table.go 83.11% <0.00%> (-0.26%) ⬇️
internal/datacoord/metrics_info.go 93.63% <0.00%> (ø)
internal/querycoord/task.go 81.13% <0.00%> (+0.19%) ⬆️
internal/indexcoord/index_coord.go 79.37% <0.00%> (+0.29%) ⬆️
internal/util/grpcclient/client.go 73.88% <0.00%> (+0.63%) ⬆️
... and 6 more

@mergify mergify bot added the ci-passed label Jan 5, 2022
@czs007
Copy link
Collaborator

czs007 commented Jan 6, 2022

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, DragonDriver

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 32eed4f into milvus-io:master Jan 6, 2022
@longjiquan longjiquan deleted the 1230-check-leakage-of-index branch December 21, 2023 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants