Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pulsar reader not close #14543

Merged

Conversation

godchen0212
Copy link
Contributor

Fix pulsar reader not close
Issue #13214

Signed-off-by: godchen0212 [email protected]

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Dec 29, 2021
@mergify mergify bot added the dco-passed DCO check passed. label Dec 29, 2021
@mergify
Copy link
Contributor

mergify bot commented Dec 29, 2021

@godchen0212 E2e jenkins job failed, comment /run-checks can trigger the job again.

@bigsheeper
Copy link
Contributor

/lgtm

@mergify
Copy link
Contributor

mergify bot commented Dec 29, 2021

@godchen0212 ut workflow job failed, comment rerun ut can trigger the job again.

@godchen0212 godchen0212 force-pushed the fix_pulsar_reader_not_close branch from 0e51f83 to 1d1ba54 Compare December 29, 2021 12:46
@sre-ci-robot sre-ci-robot removed the lgtm label Dec 29, 2021
@bigsheeper
Copy link
Contributor

/lgtm

@mergify
Copy link
Contributor

mergify bot commented Dec 29, 2021

@godchen0212 E2e jenkins job failed, comment /run-checks can trigger the job again.

3 similar comments
@mergify
Copy link
Contributor

mergify bot commented Dec 29, 2021

@godchen0212 E2e jenkins job failed, comment /run-checks can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Dec 29, 2021

@godchen0212 E2e jenkins job failed, comment /run-checks can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Dec 29, 2021

@godchen0212 E2e jenkins job failed, comment /run-checks can trigger the job again.

@godchen0212 godchen0212 force-pushed the fix_pulsar_reader_not_close branch from 1d1ba54 to 8d95cb3 Compare December 30, 2021 02:56
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed lgtm size/S Denotes a PR that changes 10-29 lines. labels Dec 30, 2021
@godchen0212 godchen0212 force-pushed the fix_pulsar_reader_not_close branch from 8d95cb3 to 9b84683 Compare December 30, 2021 03:04
@mergify
Copy link
Contributor

mergify bot commented Dec 30, 2021

@godchen0212 ut workflow job failed, comment rerun ut can trigger the job again.

@godchen0212 godchen0212 force-pushed the fix_pulsar_reader_not_close branch from 9b84683 to 50cf60b Compare December 30, 2021 07:16
@mergify
Copy link
Contributor

mergify bot commented Dec 30, 2021

@godchen0212 E2e jenkins job failed, comment /run-checks can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Dec 30, 2021

@godchen0212 ut workflow job failed, comment rerun ut can trigger the job again.

@godchen0212 godchen0212 force-pushed the fix_pulsar_reader_not_close branch from 50cf60b to 070f9ea Compare December 30, 2021 07:44
@mergify
Copy link
Contributor

mergify bot commented Dec 30, 2021

@godchen0212 E2e jenkins job failed, comment /run-checks can trigger the job again.

2 similar comments
@mergify
Copy link
Contributor

mergify bot commented Dec 30, 2021

@godchen0212 E2e jenkins job failed, comment /run-checks can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Dec 30, 2021

@godchen0212 E2e jenkins job failed, comment /run-checks can trigger the job again.

@godchen0212 godchen0212 force-pushed the fix_pulsar_reader_not_close branch from 070f9ea to 9e94b26 Compare December 30, 2021 09:30
@mergify
Copy link
Contributor

mergify bot commented Dec 30, 2021

@godchen0212 E2e jenkins job failed, comment /run-checks can trigger the job again.

5 similar comments
@mergify
Copy link
Contributor

mergify bot commented Dec 30, 2021

@godchen0212 E2e jenkins job failed, comment /run-checks can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Dec 30, 2021

@godchen0212 E2e jenkins job failed, comment /run-checks can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Dec 30, 2021

@godchen0212 E2e jenkins job failed, comment /run-checks can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Dec 31, 2021

@godchen0212 E2e jenkins job failed, comment /run-checks can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Dec 31, 2021

@godchen0212 E2e jenkins job failed, comment /run-checks can trigger the job again.

@wxyucs
Copy link
Member

wxyucs commented Dec 31, 2021

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: godchen0212, scsven

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify
Copy link
Contributor

mergify bot commented Dec 31, 2021

@godchen0212 E2e jenkins job failed, comment /run-checks can trigger the job again.

@godchen0212 godchen0212 force-pushed the fix_pulsar_reader_not_close branch from 9e94b26 to 682d3ac Compare December 31, 2021 08:50
@mergify
Copy link
Contributor

mergify bot commented Dec 31, 2021

@godchen0212 E2e jenkins job failed, comment /run-checks can trigger the job again.

5 similar comments
@mergify
Copy link
Contributor

mergify bot commented Jan 4, 2022

@godchen0212 E2e jenkins job failed, comment /run-checks can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jan 4, 2022

@godchen0212 E2e jenkins job failed, comment /run-checks can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jan 4, 2022

@godchen0212 E2e jenkins job failed, comment /run-checks can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jan 4, 2022

@godchen0212 E2e jenkins job failed, comment /run-checks can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jan 4, 2022

@godchen0212 E2e jenkins job failed, comment /run-checks can trigger the job again.

Signed-off-by: godchen0212 <[email protected]>
@godchen0212 godchen0212 force-pushed the fix_pulsar_reader_not_close branch from 682d3ac to facd464 Compare January 4, 2022 06:08
@codecov
Copy link

codecov bot commented Jan 4, 2022

Codecov Report

Merging #14543 (facd464) into master (cd43b12) will increase coverage by 0.02%.
The diff coverage is 82.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14543      +/-   ##
==========================================
+ Coverage   80.11%   80.13%   +0.02%     
==========================================
  Files         442      442              
  Lines       60912    60931      +19     
==========================================
+ Hits        48798    48828      +30     
+ Misses       9762     9751      -11     
  Partials     2352     2352              
Impacted Files Coverage Δ
internal/querynode/task.go 79.21% <0.00%> (ø)
...nternal/util/rocksmq/client/rocksmq/client_impl.go 75.63% <ø> (-2.71%) ⬇️
internal/querynode/segment_loader.go 63.40% <40.00%> (-0.44%) ⬇️
...ternal/util/rocksmq/server/rocksmq/rocksmq_impl.go 81.70% <91.66%> (-0.65%) ⬇️
internal/msgstream/mq_msgstream.go 75.54% <100.00%> (-0.24%) ⬇️
internal/util/mqclient/rmq_client.go 63.49% <100.00%> (-0.58%) ⬇️
internal/util/mqclient/rmq_consumer.go 89.18% <100.00%> (+0.61%) ⬆️
internal/util/mqclient/rmq_producer.go 100.00% <100.00%> (ø)
... and 13 more

@fishpenguin
Copy link
Contributor

/lgtm

@mergify mergify bot added the ci-passed label Jan 4, 2022
@sre-ci-robot sre-ci-robot merged commit 9e51591 into milvus-io:master Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants