Dynamic ruby version test #1
Open
+14
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rsion at the time of testing
…ith dynamic var for latest stable version
|
Hey @carolineartz! Not sure how I missed this PR, I really like it. Do you mind updating it with the current master? Also, check out my comment inline. |
| /\d.+?(?=\s)/.match(%x(rbenv versions).split("\n").last)[-1] | ||
| else | ||
| %x(rvm rubies).split("ruby-").last.split(" ").first | ||
| end |
There was a problem hiding this comment.
A few things here:
- Can you update the parsing bits to use https://github.com/mikelikesbikes/environment_linter/blob/master/test_setup.rb#L394-L431
- Pull the details out into a method
installed_rubies - Add a default for non-rvm/rbenv users, maybe just the currently running ruby in an array.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a great script. I updated
#test_ruby_versionto always check the latest available stable version of ruby instead of 2.2.0. Not sure if this is an update you'd be interested in.