Expose birth date #44
Conversation
… for calling it out of object context
|
Cool, thanks for this contribution! Could you update the README with this new functionality as well (both object oriented API and functional)? With updated doc I'll be happy to merge this 😊 |
…to avoid `any` types
|
Added missing info to the readme now, and made a small change to the mildly confusing examples on the main readme with if statements and a following line with the "output". Now showing a console log which is more in line with what you'd do to get the results shown. Also typed the object API return type to give proper return types for the functions in the object returned (was |
|
Thanks for updating the readme, and I agree with you with the |
| @@ -8,45 +51,25 @@ | |||
| * ``` | |||
| * @param idNumber norwegian social security number | |||
| */ | |||
| export const NorwegianId = (idNumber: string) => { | |||
| export const NorwegianId = (idNumber: string): NorwegianIdObject => { | |||
There was a problem hiding this comment.
OK with me, but I couldn't find that the previous type was resolved to any (ref your comment), I got that it resolved to an object:
There was a problem hiding this comment.
It resolves to an object. But if you try calling the functions on the object the inferred return types of those functions were any (for some reason) 🤷
|
Published to v3.1.0 on NPM. |
This PR adds
birthDateas a function on the object API and alls exposes thepossibleBirthDateOfIdNumberfunction that was not exported before.Having a way of getting the birthDate for an ID number would be handy, and would mean that we could stop doing chekcs for id types, subtract 4 from the 3rd digit of D-numbers etc.