Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create config file for test project targeting .NET Framework #642

Merged
merged 2 commits into from
Mar 22, 2017
Merged

Create config file for test project targeting .NET Framework #642

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f62aab0
Issue:
Faizan2304 Mar 21, 2017
90d1072
Added comment
Faizan2304 Mar 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/package/nuspec/Microsoft.NET.Test.Sdk.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,15 @@
<PropertyGroup>
<DebugType Condition="'$(TargetFrameworkIdentifier)' != '.NETCoreApp'">Full</DebugType>
</PropertyGroup>

<!--
Generate config file for test project targeting .NET Framework. This config file has have binding redirect which
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: "This config file has binding redirects needed to run tests."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

is needed at time of running tests.
-->
<PropertyGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETFramework'">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this ensure it is created only for net46 and other Desktop targets?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

<AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects>
<GenerateBindingRedirectsOutputType>true</GenerateBindingRedirectsOutputType>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to be documented in msdn: https://msdn.microsoft.com/en-us/library/2fc472t2(v=vs.110).aspx

Why is it required?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1.
https://github.com/search?l=&p=1&q=GenerateBindingRedirectsOutputType+user%3Adotnet+user%3Amicrosoft&ref=advsearch&type=Code&utf8=%E2%9C%93 is all I could find.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is required due to this piece of code
https://github.com/Microsoft/msbuild/blob/dd5e8bc3f86ac98bd77d8971b00a6ad14f122f1a/src/XMakeTasks/Microsoft.Common.CurrentVersion.targets#L2027

</PropertyGroup>

<!--
Note that this must run before every invocation of CoreCompile to ensure that all
Expand Down