Update arcade #2302
Merged
Update arcade #2302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are many changes in this PR because the eng folder was copied from the arcade source, the relevant changes are at the bottom:
|
singhsarab
reviewed
Jan 13, 2020
| "Microsoft.DotNet.Build.Tasks.Feed": "2.2.0-beta.19151.1", | ||
| "Microsoft.DotNet.Arcade.Sdk": "1.0.0-beta.19320.1" | ||
| "Microsoft.DotNet.Arcade.Sdk": "5.0.0-beta.20052.1", | ||
| "Microsoft.DotNet.Helix.Sdk": "5.0.0-beta.20052.1" |
There was a problem hiding this comment.
This is an interesting bump for a version.
@JohnTortugo Can you please help us understand why that is?
There was a problem hiding this comment.
Are we aligning with .Net 5 ?
There was a problem hiding this comment.
I asked about that: "The update to 5 was due to the release of .net 3.1"
|
Does that mean that the vstest repo is now publishing via arcade to the corresponding channel? Asking as I added a manual nuget push step in the official build defintion in devdiv. |
|
It does not, I only updated the scripts and packages to the latest arcade version. And then made sure that the build is still able to finish. No big changes to the build were done.
|
|
Got it, thanks. Is it planned to switch to the common arcade based publishing infrastructure? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update Arcade to the latest version
Related issue
Fixes #2281