Adding log prefixkey to html logger #2204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 27, 2019 16:07
singhsarab
reviewed
Oct 1, 2019
singhsarab
reviewed
Oct 1, 2019
singhsarab
reviewed
Oct 3, 2019
singhsarab
reviewed
Oct 3, 2019
singhsarab
reviewed
Oct 3, 2019
| @@ -712,7 +712,6 @@ private void ValidateDateTimeInTrx(string trxFileName) | |||
|
|
|||
| [TestMethod] | |||
| [DataRow("results")] | |||
| [DataRow("results.trx")] | |||
There was a problem hiding this comment.
instead add separate test, use data row with 2 arguments, one is the input and other expected output
There was a problem hiding this comment.
'.' is now like other alphabets right? do we really need another test case?
vagisha-nidhi
approved these changes
Oct 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding Log Prefix key for html logger