-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix regression with workdir symlinks #1053
Conversation
If a workdir was refering a symlink directory, we would pass it to yazl, which would error out because it's a directory. glob recommends using `follow: true` to consider directory symlinks as directories in the collection.
i also failed to upgrade to 3.1, and i'm using a local package: "dependencies": {
"typescript-esmsh-plugin": "./typescript-esmsh-plugin"
} |
Hello @ije, by using this PR you should be able to fix your issue. Download https://github.com/deribaucourt/vscode-vsce/tree/main then build and package vsce and install that version in your workspace. |
Thanks for looking into this. I feel we need to be a bit careful with this which is why I would propose to have this behind a cli argument. Maybe |
This new behavior fixes packaging with symlinks to directories in extensions. We make it optional in case someone wants to keep the intermediate behavior.
Thanks for your review @benibenj |
Following the vsce update, this argument is now required because we have a `lib` symlink folder. See microsoft/vscode-vsce#1053
Following the vsce update, this argument is now required because we have a `lib` symlink folder. See microsoft/vscode-vsce#1053
Following the vsce update, this argument is now required because we have a `lib` symlink folder. See microsoft/vscode-vsce#1053
See my comment in #580 (comment)
While upgrading from vsce 2.3 to 3.1, I had this regression which prevented building my package.
I use the following
package.json
extract:And this folder is a symlink.
If a workdir was refering a symlink directory, we would pass it to yazl, which would error out because it's a directory.
glob recommends using
follow: true
to consider directory symlinks as directories in the collection.