Add capability information to the metamodel #1591
Conversation
| @@ -25,6 +25,7 @@ export namespace ConfigurationRequest { | |||
| export const type = new ProtocolRequestType<ConfigurationParams, LSPAny[], never, void, void>(method); | |||
| export type HandlerSignature = RequestHandler<ConfigurationParams, LSPAny[], void>; | |||
| export type MiddlewareSignature = (params: ConfigurationParams, token: CancellationToken, next: HandlerSignature) => HandlerResult<LSPAny[], void>; | |||
| export const capabilities: { client: 'workspace.configuration'; server: 'workspace' } = { client: 'workspace.configuration', server: 'workspace' }; | |||
There was a problem hiding this comment.
@dbaeumer The spec doesn't mention a server capability for the workspace/configuration request so I'm unsure about this. Since this is requested by the server it seems like there's no server capability needed here?
| @@ -59,6 +59,7 @@ export namespace CallHierarchyPrepareRequest { | |||
| export const messageDirection: MessageDirection = MessageDirection.clientToServer; | |||
| export const type = new ProtocolRequestType<CallHierarchyPrepareParams, CallHierarchyItem[] | null, never, void, CallHierarchyRegistrationOptions>(method); | |||
| export type HandlerSignature = RequestHandler<CallHierarchyPrepareParams, CallHierarchyItem[] | null, void>; | |||
| export const capabilities: { client: 'textDocument.callHierarchy'; server: 'callHierarchyProvider' } = { client: 'textDocument.callHierarchy', server: 'callHierarchyProvider' }; | |||
There was a problem hiding this comment.
@dbaeumer Do you think we should add capability information for requests like callHierarchy/incomingCalls that don't define their own capabilities and instead depend on whether the server supports other methods (in this case textDocument/prepareCallHierarchy)?
MariaSolOs
force-pushed
the
capabilities
branch
3 times, most recently
from
c10685b to
24151f6
Compare
MariaSolOs
force-pushed
the
capabilities
branch
from
24151f6 to
9dce9a9
Compare
|
@microsoft-github-policy-service agree |
|
@MariaSolOs just a heads up. We have house keeping month in Dezember. New features have to wait until next year. |
Thanks for the heads-up. Although this isn't user facing so I wouldn't consider it a new feature per se, I understand. I'll wait until January then! |
Closes microsoft/language-server-protocol#2059.