-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Datarow tests - support methods with optional parameters and add params support #604
Datarow tests - support methods with optional parameters and add params support #604
Conversation
@ssa3512 : Thank you for your contribution!! |
@ssa3512 : Any updates on this? Let us know if you need some help on this. |
@jayaranigarg sorry, no updates yet. I'm hoping to have some time to address the feedback and look at including #283 early next week. |
@jayaranigarg I believe I addressed all feedback; should now resolve #283 as well. Please review again and let me know if anything else needs to be addressed. |
Signed-off-by: Steve Ashman <[email protected]>
Signed-off-by: Steve Ashman <[email protected]>
…unit tests for TestMethodInfo.SetParameters; add support for methods with params arguments
b7700e6
to
b77f624
Compare
@ssa3512 : Awesome work 👍 Left few minor comments, please address them and we should be all good to push this in. |
…rived class tests and rename tests to be more descriptive
@jayaranigarg if we remove the overridden tests from DerivedClass, the E2E tests run the base class tests twice - once for BaseClass and once for DerivedClass, causing the counts of passed tests to be doubled. Is it okay to specify |
@ssa3512 : Oh I see. I believe if we just keep these tests in the derived class, then they should not be executed twice. |
@jayaranigarg In that case is everything good to go? |
@ssa3512 : I have updated my comments. You can remove the tests from the base class and have them in derived class only. It will be good to go after that. |
…tively running the same tests twice
@jayaranigarg removed tests from base class and added the |
@ssa3512 : Looks nice🎉 I will go ahead and push this in. Thank you for the contributions 🥇 |
@jayaranigarg Should #283 be closed as well? |
@jnyrup: Yes. This PR adds support for params as well. Updated the title to be more explicit. |
I'd suggest updating the release notes to make it clear that In the future, I'd suggest being mindful of these changes and:
EDIT: Looks like there was a specific issue to track the params part, but we forgot to close it in time to generate the release? |
Resolves #252