test: Adding hubble metrics E2E tests. #1137
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copilot
AI
left a comment
Copilot
AI
left a comment
There was a problem hiding this comment.
Copilot reviewed 5 out of 16 changed files in this pull request and generated 1 suggestion.
Files not reviewed (11)
- test/e2e/common/validate-metric.go: Evaluated as low risk
- test/e2e/framework/constants/hubble.go: Evaluated as low risk
- test/e2e/framework/constants/networking.go: Evaluated as low risk
- test/e2e/framework/kubernetes/install-hubble-helm.go: Evaluated as low risk
- test/e2e/framework/scaletest/validate-options.go: Evaluated as low risk
- test/e2e/jobs/jobs.go: Evaluated as low risk
- test/e2e/retina_e2e_test.go: Evaluated as low risk
- test/e2e/scenarios/hubble/dns/labels.go: Evaluated as low risk
- test/e2e/scenarios/hubble/dns/scenario.go: Evaluated as low risk
- test/e2e/scenarios/hubble/drop/labels.go: Evaluated as low risk
- test/e2e/scenarios/hubble/drop/scenario.go: Evaluated as low risk
Comments skipped due to low confidence (2)
test/e2e/scenarios/hubble/tcp/labels.go:17
- The label name 'constants.HubbleIPsRetunedLabel' is misspelled. It should be 'constants.HubbleIPsReturnedLabel'.
constants.HubbleIPsRetunedLabel: "0",
test/e2e/scenarios/hubble/flow/labels.go:46
- The commented-out lines suggest there might be an issue with label generation. This should be investigated further to ensure all expected labels are generated.
// validHubbleFlowLabelsToNetwork,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please provide a brief description of the changes made in this pull request.
This PR adds E2E tests for hubble metrics.
Currently the following metrics/labels are not being generated and I am investigating why.
dop reason metrics
SYNACKlabel of TCP metrics.to-endpointandfrom-endpointhubble flow metrics.Related Issue
If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request.
Checklist
git commit -S -s ...). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
Please add any relevant screenshots or GIFs to showcase the changes made.
Additional Notes
Add any additional notes or context about the pull request here.
Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.