-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds basic infiniband grafana dashboard #1034
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Evan Baker <[email protected]>
8bb07c5
to
1038faf
Compare
Can we see a screencap of this? Sounds interesting :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we create this dashboard under the non-legacy folder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it's really an independent dashboard and you need to install it separately from the JSON, I don't think it especially matters where it lives. We're thinking about renaming "legacy" to something with less connotations such as "basic" (#1115), so maybe the current location is fine?
Added to description, it's pretty basic |
"timepicker": {}, | ||
"timezone": "browser", | ||
"title": "Infiniband", | ||
"uid": "bdzi2qzehm8zkd", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we change title/UID format to be inline with other dashboards?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ideally, let's add variables/filters for cluster + nodes like other dashboards
Description
Adds a dashboard to Grafana with basic Infiniband metric visualizations.
Related Issue
If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request.
Checklist
git commit -S -s ...
). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
Additional Notes
Add any additional notes or context about the pull request here.
Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.