Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds basic infiniband grafana dashboard #1034

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

rbtr
Copy link
Collaborator

@rbtr rbtr commented Nov 19, 2024

Description

Adds a dashboard to Grafana with basic Infiniband metric visualizations.

Related Issue

If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request.

Checklist

  • I have read the contributing documentation.
  • I signed and signed-off the commits (git commit -S -s ...). See this documentation on signing commits.
  • I have correctly attributed the author(s) of the code.
  • I have tested the changes locally.
  • I have followed the project's style guidelines.
  • I have updated the documentation, if necessary.
  • I have added tests, if applicable.

Screenshots (if applicable) or Testing Completed

image

Additional Notes

Add any additional notes or context about the pull request here.


Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.

@rbtr rbtr requested a review from a team as a code owner November 19, 2024 17:40
@rbtr rbtr force-pushed the feat/ib-dashboard branch from 8bb07c5 to 1038faf Compare November 19, 2024 17:40
@rbtr rbtr enabled auto-merge November 19, 2024 17:40
@rbtr rbtr self-assigned this Nov 19, 2024
@timraymond
Copy link
Member

Can we see a screencap of this? Sounds interesting :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we create this dashboard under the non-legacy folder?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's really an independent dashboard and you need to install it separately from the JSON, I don't think it especially matters where it lives. We're thinking about renaming "legacy" to something with less connotations such as "basic" (#1115), so maybe the current location is fine?

@rbtr
Copy link
Collaborator Author

rbtr commented Dec 11, 2024

Can we see a screencap of this? Sounds interesting :)

Added to description, it's pretty basic

"timepicker": {},
"timezone": "browser",
"title": "Infiniband",
"uid": "bdzi2qzehm8zkd",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we change title/UID format to be inline with other dashboards?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally, let's add variables/filters for cluster + nodes like other dashboards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants