Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry Pick 0.62-stable deadlock fix #736

Merged

Conversation

Saadnajmi
Copy link
Collaborator

@Saadnajmi Saadnajmi commented Feb 26, 2021

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

Cherry Pick 24c16b1 into 0.62-stable

Changelog

[iOS] [Fixed] - Fix deadlock on RCTi18nUtil

Test Plan

Microsoft Reviewers: Open in CodeFlow

* Initial Commit

* Fix typo

* Fix default initialization of isRTLAllowed and documentation

* use BOOL, remove superfluous readwrite decorator

* Fix another typo

* Add TODO Marker
@Saadnajmi Saadnajmi requested a review from tom-un as a code owner February 26, 2021 18:32
@Saadnajmi Saadnajmi requested a review from HeyImChris February 26, 2021 18:35
@HeyImChris HeyImChris merged commit 660cb7e into microsoft:0.62-stable Feb 26, 2021
@Saadnajmi Saadnajmi deleted the 0.62-stable-deadlock-fix branch February 26, 2021 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants