Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented first cut at generalized support for dataclass transforms. #1773

Merged
merged 6 commits into from
Apr 21, 2021
Merged

Implemented first cut at generalized support for dataclass transforms. #1773

merged 6 commits into from
Apr 21, 2021

Conversation

erictraut
Copy link
Collaborator

No description provided.

@erictraut erictraut merged commit 743694e into master Apr 21, 2021
This was referenced Apr 23, 2021
Closed
Open
@erictraut erictraut deleted the erictr/dataclass_transforms branch June 15, 2021 07:12
heejaechang added a commit to heejaechang/pyright that referenced this pull request Nov 3, 2021
@heejaechang
Allow only 1 Uri per a file (microsoft#1773)
17b9be1 
* make sure we only accept 1 uri for 1 file and ignore any other calls to the same file with different uri scheme. currently, Pyright can't handle this kind of case since everything is de-duplicated with file path not uri. so once uri is de-dupped to file path, there is no way to know which uri it should use to return results when there are mulitple uris mapped to same path.

we can only support multiple uris to a same file case when we refactor pylance/pyright to uri based.

* added tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakebailey jakebailey jakebailey left review comments

@gvanrossum gvanrossum gvanrossum left review comments

@heejaechang heejaechang heejaechang left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@erictraut @heejaechang @gvanrossum @jakebailey @msfterictraut