TeacherTool path rename #10316
Open
TeacherTool path rename #10316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abchatra
approved these changes
Dec 12, 2024
thsparks
requested changes
Dec 12, 2024
There was a problem hiding this comment.
I would not recommend changing the paths on these files. At least not yet. We have it hard-coded here and here
We probably shouldn't hard code them, but until we fix that, changing the location of these files will break our ability to load the catalogs.
That said, these URLs shouldn't be user-facing anyway. Not sure if there's much reason to change them. Is it necessary for updating the https://makecode.microbit.org/teachertool URL?
|
@ganicke may be sufficient to rename this md? https://github.com/Microsoft/pxt-microbit/blob/master/docs/teachertool.md |
|
If we do move forward with this, we'll need to change those hard-coded paths and hotfix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename doc paths of
./teachertoolto./code-eval-tool. This is to support the changes for microsoft/pxt-microbit#6036.