Fix localisation of help docs for langs like 'fr' #10310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For French the code is 'fr' which just returns a single part. We can just use whichever parts are returned for the paths.
riknoll
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
ah, i messed up when copying that check from https://github.com/microsoft/pxt/blob/master/pxtlib/tutorial.ts#L516
riknoll
pushed a commit
that referenced
this pull request
Dec 9, 2024
For French the code is 'fr' which just returns a single part. We can just use whichever parts are returned for the paths.
abchatra
pushed a commit
that referenced
this pull request
Dec 9, 2024
For French the code is 'fr' which just returns a single part. We can just use whichever parts are returned for the paths. Co-authored-by: Matt Hillsdon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For French the code is 'fr' which just returns a single part. We can just use whichever parts are returned for the paths.
@riknoll spotted this testing out #10307, we were lucky/unlucky enough to pick French to try it out.