Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(launch): do not wait for first page in non-persistent mode #939

Merged
merged 1 commit into from
Feb 13, 2020
Merged

fix(launch): do not wait for first page in non-persistent mode #939

merged 1 commit into from
Feb 13, 2020

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Feb 12, 2020

No description provided.

@aslushnikov
Copy link
Collaborator

Looks like a test fails

Chromium Browser target events should work (launcher.spec.js:58:5)

@pavelfeldman pavelfeldman merged commit a567123 into microsoft:master Feb 13, 2020
aslushnikov added a commit that referenced this pull request Feb 13, 2020
@aslushnikov
Revert "feat: do not wait for first page in non-persistent mode (#939)"
71892b4 
This reverts commit a567123.

Reason for revert: WK-Win fails to start if we start talking over the
pipe too early.
aslushnikov added a commit that referenced this pull request Feb 13, 2020
@aslushnikov
Revert "Revert "feat: do not wait for first page in non-persistent mo…
f8f818f 
…de (#939)""

Apparently a good fix is coming: #993
Pavel want to re-revert.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelfeldman pavelfeldman pavelfeldman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dgozman @aslushnikov @pavelfeldman