Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

browser(firefox): attach to all pages in the browser context #928

Merged
merged 1 commit into from
Feb 11, 2020
Merged

browser(firefox): attach to all pages in the browser context #928

merged 1 commit into from
Feb 11, 2020

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Feb 11, 2020

  • introduce BrowserContext abstraction;
  • attach to all pages from owned browser contexts on creation;
  • move page emulation to PageTarget/FrameTree, away from sessions and agents;
  • remove explicit enable methods, replaced by Page.ready event;
  • pass browser context options on creation.

dgozman/gecko-dev@c73fb44

@dgozman
browser(firefox): attach to all pages in the browser context
fa6e8a7 
- introduce BrowserContext abstraction;
- attach to all pages from owned browser contexts on creation;
- move page emulation to PageTarget/FrameTree, away from sessions and agents;
- remove explicit enable methods, replaced by Page.ready event;
- pass browser context options on creation.
@aslushnikov aslushnikov merged commit 9ea8f49 into microsoft:master Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aslushnikov aslushnikov aslushnikov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dgozman @aslushnikov