Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce browserType.downloadBrowserIfNeeded() #834

Merged
merged 1 commit into from
Feb 11, 2020

Conversation

aslushnikov
Copy link
Collaborator

Fixes #823

Copy link
Member

@pavelfeldman pavelfeldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No tests?

@aslushnikov aslushnikov force-pushed the expose-browser-downloads branch from cf834ef to d90263f Compare February 11, 2020 18:51
@aslushnikov
Copy link
Collaborator Author

No tests?

This is a part of //download-browser.js now that is executed on every ci run.

@aslushnikov aslushnikov merged commit ad9d6cc into microsoft:master Feb 11, 2020
@aslushnikov aslushnikov deleted the expose-browser-downloads branch February 11, 2020 19:33
sand4rt pushed a commit to sand4rt/playwright that referenced this pull request Dec 21, 2022
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Allow skipping specific browser downloads
3 participants