Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(accessibility): Remove unused browser goldens #758

Merged
merged 1 commit into from
Jan 30, 2020

Conversation

kblok
Copy link
Contributor

@kblok kblok commented Jan 30, 2020

Tell me if this makes sense.

Describe plainttext contenteditable is not running on Firefox and Webkit. Therefore we shouldn't need those specific node values.

@msftclas
Copy link

msftclas commented Jan 30, 2020

CLA assistant check
All CLA requirements met.

Copy link
Collaborator

@aslushnikov aslushnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, totally. Thank you for cleaning dead code!

@aslushnikov aslushnikov merged commit d590ab9 into microsoft:master Jan 30, 2020
@kblok kblok deleted the tests/accessibility-tests branch January 30, 2020 20:12
JoelEinbinder added a commit that referenced this pull request Jan 30, 2020
aslushnikov pushed a commit that referenced this pull request Jan 30, 2020
…763)

Not dead code, this caused these tests to fail in firefox.
Reverts #758
sand4rt pushed a commit to sand4rt/playwright that referenced this pull request Dec 21, 2022
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants