fix: move offline/cache/interception switches to BrowserContext #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgozman
reviewed
Jan 29, 2020
| @@ -91,17 +97,19 @@ export class CRNetworkManager { | |||
| } | |||
|
|
|||
| async setCacheEnabled(enabled: boolean) { | |||
There was a problem hiding this comment.
Why do we have a parameter which is now ignored?
There was a problem hiding this comment.
This is how it is declared in the delegate interface. 2 other browsers use that param. We can update that in a separate change.
| @@ -90,6 +90,8 @@ export class FFPage implements PageDelegate { | |||
| promises.push(this._session.send('Page.setJavascriptEnabled', { enabled: false })); | |||
| if (options.userAgent) | |||
| promises.push(this._session.send('Page.setUserAgent', { userAgent: options.userAgent })); | |||
| if (options.cacheEnabled === false) | |||
There was a problem hiding this comment.
It seems like this is missing request interception changes in firefox.
| return !!this._page.browserContext()._options.interceptNetwork; | ||
| } | ||
|
|
||
| private async _updateProtocolRequestInterception() { |
There was a problem hiding this comment.
This stuff is too complicated 😞
There was a problem hiding this comment.
it is, let me change that in a follow-up.
dgozman
approved these changes
Jan 29, 2020
pavelfeldman
added a commit
to pavelfeldman/playwright
that referenced
this pull request
Feb 1, 2020
…xt (microsoft#748)" This reverts commit 6faf74b.
sand4rt
pushed a commit
to sand4rt/playwright
that referenced
this pull request
Dec 21, 2022
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.