feat(inspector): send api names along with metainfo (step 1) #5518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelfeldman
changed the title
dgozman
approved these changes
Feb 19, 2021
| @@ -84,11 +84,11 @@ export abstract class ChannelOwner<T extends channels.Channel = channels.Channel | |||
| }; | |||
| } | |||
|
|
|||
| async _wrapApiCall<T>(apiName: string, func: () => Promise<T>, logger?: Logger): Promise<T> { | |||
| async _wrapApiCall<T, K extends channels.Channel>(apiName: string, func: (channel: K) => Promise<T>, logger?: Logger): Promise<T> { | |||
There was a problem hiding this comment.
async _wrapApiCall<R>(apiName: string, func: (channel: T) => Promise<R>, logger?: Logger): Promise<R> {
I believe this should infer the channel type from ChannelOwner<T> and you would not have to write channel: channels.FooChannel everywhere.
| logger = logger || this._logger; | ||
| try { | ||
| logApiCall(logger, `=> ${apiName} started`); | ||
| const result = await func(); | ||
| const result = await func(this._channel as any); |
There was a problem hiding this comment.
Should we make this._channel private so that we always wrap with some api name?
pavelfeldman
force-pushed
the
api_call
branch
from
2718ffc to
2254114
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.