Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): added recent apps button #5331

Merged
merged 2 commits into from
Feb 17, 2021

Conversation

NareshMurthy
Copy link
Contributor

@NareshMurthy NareshMurthy commented Feb 5, 2021

Added new android keys for playwright-android - AppSwitch, Assist, Cut, Copy, Paste
Modified android key from 'At' to '@'
Fixes #5216

@ghost
Copy link

ghost commented Feb 5, 2021

CLA assistant check
All CLA requirements met.

@pavelfeldman
Copy link
Member

pavelfeldman commented Feb 5, 2021

They call it KEYCODE_APP_SWITCH, should we rename to AppSwitch?

Also, while you are there, could you add these?
...
['@', 77],
...
['AppSwitch', 187],
['Assist', 219],
['Cut', 277],
['Copy', 278],
['Paste', 279],

I had them in a patch that never got uploaded.

@NareshMurthy
Copy link
Contributor Author

@pavelfeldman I've added the below keys

New keys
['AppSwitch', 187],
['Assist', 219],
['Cut', 277],
['Copy', 278],
['Paste', 279],

Modified
['At', 77], to ['@', 77],

@pavelfeldman
Copy link
Member

Oh, missed it, let me try resolving the conflict and landing it!

Added a new android key - RecentApps
Fixes microsoft#5216
Added new android keys for playwright-android - AppSwitch, Assist, Cut, Copy, Paste
Modified a android key from 'At' to '@'
Fixes microsoft#5216
@pavelfeldman pavelfeldman merged commit cc749fe into microsoft:master Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Question] How to lock screen using playwright-android?
2 participants