Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webkit): update Docker file to include gstreamer #2636

Merged
merged 2 commits into from
Jun 19, 2020
Merged

fix(webkit): update Docker file to include gstreamer #2636

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
befa356
fix(webkit): update Docker file to include gstreamer
yury-s Jun 18, 2020
26b43c1
Reverted test changes
yury-s Jun 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions docs/docker/Dockerfile.bionic
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,28 +31,34 @@ RUN apt-get install -y libwoff1 \
libgles2 \
libvpx5

# 3. Install Chromium dependencies
# 3. Install gstreamer and plugins to support video playback in WebKit.
RUN apt-get install -y gstreamer1.0-gl \
gstreamer1.0-plugins-base \
gstreamer1.0-plugins-good \
gstreamer1.0-plugins-bad

# 4. Install Chromium dependencies

RUN apt-get install -y libnss3 \
libxss1 \
libasound2 \
fonts-noto-color-emoji

# 4. Install Firefox dependencies
# 5. Install Firefox dependencies

RUN apt-get install -y libdbus-glib-1-2 \
libxt6

# 5. Install ffmpeg to bring in audio and video codecs necessary for playing videos in Firefox.
# 6. Install ffmpeg to bring in audio and video codecs necessary for playing videos in Firefox.

RUN apt-get install -y ffmpeg

# 6. Add user so we don't need --no-sandbox in Chromium
# 7. Add user so we don't need --no-sandbox in Chromium
RUN groupadd -r pwuser && useradd -r -g pwuser -G audio,video pwuser \
&& mkdir -p /home/pwuser/Downloads \
&& chown -R pwuser:pwuser /home/pwuser

# 7. (Optional) Install XVFB if there's a need to run browsers in headful mode
# 8. (Optional) Install XVFB if there's a need to run browsers in headful mode
RUN apt-get install -y xvfb

# Run everything after as non-privileged user.
Expand Down
4 changes: 2 additions & 2 deletions test/capabilities.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* limitations under the License.
*/

const {FFOX, CHROMIUM, WEBKIT, WIN} = require('./utils').testOptions(browserType);
const {FFOX, CHROMIUM, WEBKIT, WIN, LINUX} = require('./utils').testOptions(browserType);

describe('Capabilities', function() {
it.fail(WEBKIT && WIN)('Web Assembly should work', async function({page, server}) {
Expand Down Expand Up @@ -47,7 +47,7 @@ describe('Capabilities', function() {
await page.goto(server.EMPTY_PAGE);
expect(await page.evaluate(() => window.testStatus)).toBe('SUCCESS');
});
it.fail(WEBKIT)('should play video', async({page, server}) => {
it.fail(WEBKIT && !LINUX)('should play video', async({page, server}) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait, we don't play video on mac / win?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to Dmitry on mac there is a problem with our test server which doesn't support range query, so we should fix that. I will check if it works on windows and enable there separately.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverting the test change for now, will enable it along with the roll.

await page.goto(server.PREFIX + '/video.html');
await page.$eval('video', v => v.play());
await page.$eval('video', v => v.pause());
Expand Down