Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(actions): requery the element when it was detached during the action #1853

Merged
merged 1 commit into from
Apr 19, 2020
Merged

feat(actions): requery the element when it was detached during the action #1853

merged 1 commit into from
Apr 19, 2020

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Apr 17, 2020 •
edited
Loading

Fixes #1780.

pavelfeldman
pavelfeldman approved these changes Apr 18, 2020
View reviewed changes
src/frames.ts Show resolved Hide resolved
src/frames.ts Show resolved Hide resolved
@dgozman dgozman changed the title feat(click): retry click if element was detached during click feat(actions): requery the element when it was detached during the action Apr 18, 2020
@dgozman dgozman merged commit 55b4bc9 into microsoft:master Apr 19, 2020
@snyk-bot snyk-bot mentioned this pull request May 27, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelfeldman pavelfeldman pavelfeldman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] page.click(selector) should skip intermediate elements
2 participants
@dgozman @pavelfeldman