Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): meaningful split between test.js and playwright.spec.js #1630

Merged
merged 1 commit into from
Apr 2, 2020
Merged

chore(tests): meaningful split between test.js and playwright.spec.js #1630

merged 1 commit into from
Apr 2, 2020

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Apr 1, 2020

CLI handling goes to test.js.
Everything about running tests goes to playwright.spec.js.

This will help isplaywrightready and future jest integration.

CLI handling goes to test.js.
Everything about running tests goes to playwright.spec.js.

This will help isplaywrightready and future jest integration.
if (typeof module.xdescribe === 'function')
xdescribe('', module.xdescribe, testOptions);
}
const sourcePort = port + 2;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is probably not needed any more

@dgozman dgozman merged commit 14dbf4a into microsoft:master Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants