fix: wait for the process to close when closing the browser #1629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yury-s
approved these changes
Apr 2, 2020
src/firefox/ffBrowser.ts
Outdated
| await Promise.all(this.contexts().map(context => context.close())); | ||
| helper.removeEventListeners(this._eventListeners); | ||
| const disconnected = new Promise(f => this.once(Events.Browser.Disconnected, f)); | ||
| this._connection.close(); | ||
| await disconnected; | ||
| } | ||
|
|
||
| async close() { | ||
| if (this._closeOverride) |
There was a problem hiding this comment.
nit: Pavel suggested you could use this.__server__.close() if server is set instead of passing the callback. *Broser.close() implementation would be a bit more obvious then.
There was a problem hiding this comment.
We can make it this._server to make it more legit
There was a problem hiding this comment.
done as _ownedServer
| @@ -135,7 +135,7 @@ export async function launchProcess(options: LaunchProcessOptions): Promise<Laun | |||
| } | |||
| gracefullyClosing = true; | |||
| debugBrowser(`<gracefully close start>`); | |||
| options.attemptToGracefullyClose().catch(() => killProcess()); | |||
| await options.attemptToGracefullyClose().catch(() => killProcess()); | |||
There was a problem hiding this comment.
if killProcess throws, the error will appear in the right place, among other subtle changes. I always prefer to await promises.
JoelEinbinder
force-pushed
the
refactor_launching
branch
from
0af34b9 to
4f07bc9
Compare
JoelEinbinder
force-pushed
the
refactor_launching
branch
from
4f07bc9 to
a24ead1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a test, but it was chromium only (reading the cookies file). I'll work on a better one.