Revert "browser(firefox): instrument all windows, support silent mode… #1615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…microsoft#1612)" This reverts commit 314eb40. Tests are hanging on Linux: Testing on Node v12.6.0 WARN: running Firefox tests with /home/yurys/playwright/browser_patches/firefox/checkout/obj-build-playwright/dist/bin/firefox Running 1 focused tests out of total 984 on 20 workers Focused Suites and Tests: 1) Firefox [Driver] Page.evaluate should work (evaluation.spec.js:31:5) pw:browser:proc:[1] <launching> /home/yurys/playwright/browser_patches/firefox/checkout/obj-build-playwright/dist/bin/firefox -no-remote -headless -profile /tmp/playwright_dev_firefox_profile-WlBvTh -juggler 0 about:blank +0ms pw:browser:err:[1] *** You are running in headless mode. +0ms pw:browser:out:[1] 1585699649772 [email protected] WARN Loading extension '[email protected]': Reading manifest: Invalid extension permission: networkStatus +0ms pw:browser:out:[1] 1585699650540 [email protected] WARN Loading extension '[email protected]': Reading manifest: Invalid extension permission: mozillaAddons +768ms pw:browser:out:[1] 1585699650541 [email protected] WARN Loading extension '[email protected]': Reading manifest: Invalid extension permission: telemetry +0ms pw:browser:out:[1] 1585699650541 [email protected] WARN Loading extension '[email protected]': Reading manifest: Invalid extension permission: resource://pdf.js/ +0ms pw:browser:out:[1] 1585699650541 [email protected] WARN Loading extension '[email protected]': Reading manifest: Invalid extension permission: about:reader* +0ms pw:browser:out:[1] Juggler listening on ws://127.0.0.1:33883/a943e269-48d9-494c-819f-ab533724739d +171ms pw:protocol SEND ► {"id":1,"method":"Browser.enable","params":{"attachToDefaultContext":false}} +0ms Failures: 1) [worker = null] [CRASHED] Firefox [Driver] Page.evaluate should work (evaluation.spec.js:31:5)
aslushnikov
reviewed
Apr 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… (#1612)"
This reverts commit 314eb40.
Tests are hanging on Linux:
Testing on Node v12.6.0
WARN: running Firefox tests with /home/yurys/playwright/browser_patches/firefox/checkout/obj-build-playwright/dist/bin/firefox
Running 1 focused tests out of total 984 on 20 workers
Focused Suites and Tests:
pw:browser:proc:[1] /home/yurys/playwright/browser_patches/firefox/checkout/obj-build-playwright/dist/bin/firefox -no-remote -headless -profile /tmp/playwright_dev_firefox_profile-WlBvTh -juggler 0 about:blank +0ms
pw:browser:err:[1] *** You are running in headless mode. +0ms
pw:browser:out:[1] 1585699649772 [email protected] WARN Loading extension '[email protected]': Reading manifest: Invalid extension permission: networkStatus +0ms
pw:browser:out:[1] 1585699650540 [email protected] WARN Loading extension '[email protected]': Reading manifest: Invalid extension permission: mozillaAddons +768ms
pw:browser:out:[1] 1585699650541 [email protected] WARN Loading extension '[email protected]': Reading manifest: Invalid extension permission: telemetry +0ms
pw:browser:out:[1] 1585699650541 [email protected] WARN Loading extension '[email protected]': Reading manifest: Invalid extension permission: resource://pdf.js/ +0ms
pw:browser:out:[1] 1585699650541 [email protected] WARN Loading extension '[email protected]': Reading manifest: Invalid extension permission: about:reader* +0ms
pw:browser:out:[1] Juggler listening on ws://127.0.0.1:33883/a943e269-48d9-494c-819f-ab533724739d +171ms
pw:protocol SEND ► {"id":1,"method":"Browser.enable","params":{"attachToDefaultContext":false}} +0ms
Failures: