chore(waitForEvent): refactor waitForEvent into a single implementation #1602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgozman
reviewed
Mar 31, 2020
src/page.ts
Outdated
| @@ -111,7 +112,10 @@ export class Page extends platform.EventEmitter { | |||
| _ownedContext: BrowserContext | undefined; | |||
|
|
|||
| constructor(delegate: PageDelegate, browserContext: BrowserContextBase) { | |||
| super(); | |||
| super({ | |||
There was a problem hiding this comment.
Since we already inherit, perhaps use overridden methods instead?
dgozman
approved these changes
Mar 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the
waitForEventimplementation into anExtendedEventEmitterclass.This is step one if we want to add
waitForEventtoWorker,Browser, andBrowserServerobjects. All of these only have a 'close' event, but I still feel we should be consistent with our event emitters.